netdev - RE: [PATCH net-next 12/33] hv_netvsc: add XDP frame size to driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Apr 2020 16:57:05 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        "sameehj@...zon.com" <sameehj@...zon.com>
CC:     Wei Liu <wei.liu@...nel.org>, KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "zorik@...zon.com" <zorik@...zon.com>,
        "akiyano@...zon.com" <akiyano@...zon.com>,
        "gtzalik@...zon.com" <gtzalik@...zon.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        John Fastabend <john.fastabend@...il.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        David Ahern <dsahern@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "steffen.klassert@...unet.com" <steffen.klassert@...unet.com>
Subject: RE: [PATCH net-next 12/33] hv_netvsc: add XDP frame size to driver



> -----Original Message-----
> From: Jesper Dangaard Brouer <brouer@...hat.com>
> Sent: Wednesday, April 22, 2020 12:08 PM
> To: sameehj@...zon.com
> Cc: Wei Liu <wei.liu@...nel.org>; KY Srinivasan <kys@...rosoft.com>;
> Haiyang Zhang <haiyangz@...rosoft.com>; Stephen Hemminger
> <sthemmin@...rosoft.com>; Jesper Dangaard Brouer
> <brouer@...hat.com>; netdev@...r.kernel.org; bpf@...r.kernel.org;
> zorik@...zon.com; akiyano@...zon.com; gtzalik@...zon.com; Toke
> Høiland-Jørgensen <toke@...hat.com>; Daniel Borkmann
> <borkmann@...earbox.net>; Alexei Starovoitov
> <alexei.starovoitov@...il.com>; John Fastabend
> <john.fastabend@...il.com>; Alexander Duyck
> <alexander.duyck@...il.com>; Jeff Kirsher <jeffrey.t.kirsher@...el.com>;
> David Ahern <dsahern@...il.com>; Willem de Bruijn
> <willemdebruijn.kernel@...il.com>; Ilias Apalodimas
> <ilias.apalodimas@...aro.org>; Lorenzo Bianconi <lorenzo@...nel.org>;
> Saeed Mahameed <saeedm@...lanox.com>;
> steffen.klassert@...unet.com
> Subject: [PATCH net-next 12/33] hv_netvsc: add XDP frame size to driver
> 
> The hyperv NIC drivers XDP implementation is rather disappointing as it will
> be a slowdown to enable XDP on this driver, given it will allocate a new page
> for each packet and copy over the payload, before invoking the XDP BPF-
> prog.

This statement is not accurate -- The data path of netvsc driver does memory 
allocation and copy even without XDP, so it's not "a slowdown to enable XDP".

Thanks,
- Haiyang