netdev - Re: [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz1vgJG=z4u3h=OkPynf0TVBt9ih2XvwSO1d-GHNYNTxrg@mail.gmail.com>
Date:   Wed, 22 Apr 2020 07:37:43 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] xsk: Fix typo in xsk_umem_consume_tx and xsk_generic_xmit comments

On Wed, Apr 22, 2020 at 1:30 AM Tobias Klauser <tklauser@...tanz.ch> wrote:
>
> s/backpreassure/backpressure/

Thanks Tobias.

Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>

> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---
>  net/xdp/xsk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index c350108aa38d..f6e6609f70a3 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -322,7 +322,7 @@ bool xsk_umem_consume_tx(struct xdp_umem *umem, struct xdp_desc *desc)
>                 if (!xskq_cons_peek_desc(xs->tx, desc, umem))
>                         continue;
>
> -               /* This is the backpreassure mechanism for the Tx path.
> +               /* This is the backpressure mechanism for the Tx path.
>                  * Reserve space in the completion queue and only proceed
>                  * if there is space in it. This avoids having to implement
>                  * any buffering in the Tx path.
> @@ -406,7 +406,7 @@ static int xsk_generic_xmit(struct sock *sk)
>                 addr = desc.addr;
>                 buffer = xdp_umem_get_data(xs->umem, addr);
>                 err = skb_store_bits(skb, 0, buffer, len);
> -               /* This is the backpreassure mechanism for the Tx path.
> +               /* This is the backpressure mechanism for the Tx path.
>                  * Reserve space in the completion queue and only proceed
>                  * if there is space in it. This avoids having to implement
>                  * any buffering in the Tx path.
> --
> 2.26.1
>