netdev - Re: [PATCH net 0/2] net: Fix looping with vrf, xfrms and qdisc on VRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200422.123259.1847780703992561178.davem@davemloft.net>
Date:   Wed, 22 Apr 2020 12:32:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, trev@...ock.ca,
        dsahern@...il.com
Subject: Re: [PATCH net 0/2] net: Fix looping with vrf, xfrms and qdisc on
 VRF

From: David Ahern <dsahern@...nel.org>
Date: Mon, 20 Apr 2020 17:13:50 -0600

> From: David Ahern <dsahern@...il.com>
> 
> Trev reported that use of VRFs with xfrms is looping when a qdisc
> is added to the VRF device. The combination of xfrm + qdisc is not
> handled by the VRF driver which lost track that it has already
> seen the packet.
> 
> The XFRM_TRANSFORMED flag is used by the netfilter code for a similar
> purpose, so re-use for VRF. Patch 1 drops the #ifdef around setting
> the flag in the xfrm output functions. Patch 2 adds a check to
> the VRF driver for flag; if set the packet has already passed through
> the VRF driver once and does not need to recirculated a second time.
> 
> This is a day 1 bug with VRFs; stable wise, I would only take this
> back to 4.14. I have a set of test cases which I will submit to
> net-next.

Series applied and queued up for -stable, thanks David.