netdev - Re: [PATCH net-next 14/33] net: ethernet: ti: add XDP frame size to driver cpsw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <340e0da5-8c0a-5719-45a5-94ce4a26a1fa@ti.com>
Date:   Wed, 22 Apr 2020 23:28:48 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>, <sameehj@...zon.com>
CC:     Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <zorik@...zon.com>, <akiyano@...zon.com>, <gtzalik@...zon.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        John Fastabend <john.fastabend@...il.com>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        David Ahern <dsahern@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        <steffen.klassert@...unet.com>
Subject: Re: [PATCH net-next 14/33] net: ethernet: ti: add XDP frame size to
 driver cpsw



On 22/04/2020 19:08, Jesper Dangaard Brouer wrote:
> The driver code cpsw.c and cpsw_new.c both use page_pool
> with default order-0 pages or their RX-pages.
> 
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---
>   drivers/net/ethernet/ti/cpsw.c     |    1 +
>   drivers/net/ethernet/ti/cpsw_new.c |    1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf87da01..58e346ea9898 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -406,6 +406,7 @@ static void cpsw_rx_handler(void *token, int len, int status)
>   
>   		xdp.data_hard_start = pa;
>   		xdp.rxq = &priv->xdp_rxq[ch];
> +		xdp.frame_sz = PAGE_SIZE;
>   
>   		port = priv->emac_port + cpsw->data.dual_emac;
>   		ret = cpsw_run_xdp(priv, ch, &xdp, page, port);
> diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
> index 9209e613257d..08e1c5b8f00e 100644
> --- a/drivers/net/ethernet/ti/cpsw_new.c
> +++ b/drivers/net/ethernet/ti/cpsw_new.c
> @@ -348,6 +348,7 @@ static void cpsw_rx_handler(void *token, int len, int status)
>   
>   		xdp.data_hard_start = pa;
>   		xdp.rxq = &priv->xdp_rxq[ch];
> +		xdp.frame_sz = PAGE_SIZE;
>   
>   		ret = cpsw_run_xdp(priv, ch, &xdp, page, priv->emac_port);
>   		if (ret != CPSW_XDP_PASS)
> 
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
Best regards,
grygorii