lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Apr 2020 16:27:05 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Mao Wenan <maowenan@...wei.com> Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, john fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH bpf-next 2/2] libbpf: Return err if bpf_object__load failed On Wed, Apr 22, 2020 at 1:30 AM Mao Wenan <maowenan@...wei.com> wrote: > > bpf_object__load() has various return code, when > it failed to load object, it must return err instead > of return -EINVAL. > > Signed-off-by: Mao Wenan <maowenan@...wei.com> > --- This patch looks good. The other one in this series - not so sure.. Acked-by: Andrii Nakryiko <andriin@...com> > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 8f480e29a6b0..8e1dc6980fac 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -7006,7 +7006,7 @@ int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr, > err = bpf_object__load(obj); > if (err) { > bpf_object__close(obj); > - return -EINVAL; > + return err; > } > > *pobj = obj; > -- > 2.20.1 >
Powered by blists - more mailing lists