netdev - RE: [EXT] [PATCH -next] qed: Make ll2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 07:44:02 +0000
From:   Michal Kalderon <mkalderon@...vell.com>
To:     Zou Wei <zou_wei@...wei.com>, Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH -next] qed: Make ll2_cbs static

> From: Zou Wei <zou_wei@...wei.com>
> Sent: Thursday, April 23, 2020 10:28 AM
> 
> ----------------------------------------------------------------------
> Fix the following sparse warning:
> 
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
> was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> index 037e597..4afd857 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> @@ -2331,7 +2331,7 @@ static void qed_ll2_register_cb_ops(struct qed_dev
> *cdev,
>  	cdev->ll2->cb_cookie = cookie;
>  }
> 
> -struct qed_ll2_cbs ll2_cbs = {
> +static struct qed_ll2_cbs ll2_cbs = {
>  	.rx_comp_cb = &qed_ll2b_complete_rx_packet,
>  	.rx_release_cb = &qed_ll2b_release_rx_packet,
>  	.tx_comp_cb = &qed_ll2b_complete_tx_packet,
> --
> 2.6.2

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@...vell.com>