[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200423080627.GA3616668@splinter>
Date: Thu, 23 Apr 2020 11:06:27 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] mlxsw: Fix some IS_ERR() vs NULL bugs
On Wed, Apr 22, 2020 at 12:36:41PM +0300, Dan Carpenter wrote:
> The mlxsw_sp_acl_rulei_create() function is supposed to return an error
> pointer from mlxsw_afa_block_create(). The problem is that these
> functions both return NULL instead of error pointers. Half the callers
> expect NULL and half expect error pointers so it could lead to a NULL
> dereference on failure.
>
> This patch changes both of them to return error pointers and changes all
> the callers which checked for NULL to check for IS_ERR() instead.
>
> Fixes: 4cda7d8d7098 ("mlxsw: core: Introduce flexible actions support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Reviewed-by: Ido Schimmel <idosch@...lanox.com>
Thanks, Dan.
Powered by blists - more mailing lists