lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Apr 2020 09:33:17 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> To: John Stultz <john.stultz@...aro.org>, lkml <linux-kernel@...r.kernel.org> CC: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Jakub Kicinski <kuba@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J . Wysocki" <rjw@...ysocki.net>, Rob Herring <robh@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, Robin Murphy <robin.murphy@....com>, Andy Shevchenko <andy.shevchenko@...il.com>, Sudeep Holla <sudeep.holla@....com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Naresh Kamboju <naresh.kamboju@...aro.org>, Basil Eljuse <Basil.Eljuse@....com>, Ferry Toth <fntoth@...il.com>, Arnd Bergmann <arnd@...db.de>, Anders Roxell <anders.roxell@...aro.org>, netdev <netdev@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org> Subject: RE: [PATCH v3 2/3] driver core: Use dev_warn() instead of dev_WARN() for deferred_probe_timeout warnings Hi John, > From: John Stultz, Sent: Thursday, April 23, 2020 5:33 AM > > In commit c8c43cee29f6 ("driver core: Fix > driver_deferred_probe_check_state() logic") and following > changes the logic was changes slightly so that if there is no > driver to match whats found in the dtb, we wait the sepcified > seconds for modules to be loaded by userland, and then timeout, > where as previously we'd print "ignoring dependency for device, > assuming no driver" and immediately return -ENODEV after > initcall_done. > > However, in the timeout case (which previously existed but was > practicaly un-used without a boot argument), the timeout message > uses dev_WARN(). This means folks are now seeing a big backtrace > in their boot logs if there a entry in their dts that doesn't > have a driver. > > To fix this, lets use dev_warn(), instead of dev_WARN() to match > the previous error path. > > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org> > Cc: Jakub Kicinski <kuba@...nel.org> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: Rafael J. Wysocki <rjw@...ysocki.net> > Cc: Rob Herring <robh@...nel.org> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> > Cc: Robin Murphy <robin.murphy@....com> > Cc: Andy Shevchenko <andy.shevchenko@...il.com> > Cc: Sudeep Holla <sudeep.holla@....com> > Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > Cc: Naresh Kamboju <naresh.kamboju@...aro.org> > Cc: Basil Eljuse <Basil.Eljuse@....com> > Cc: Ferry Toth <fntoth@...il.com> > Cc: Arnd Bergmann <arnd@...db.de> > Cc: Anders Roxell <anders.roxell@...aro.org> > Cc: netdev <netdev@...r.kernel.org> > Cc: linux-pm@...r.kernel.org > Fixes: c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state() logic") > Signed-off-by: John Stultz <john.stultz@...aro.org> > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> Best regards, Yoshihiro Shimoda
Powered by blists - more mailing lists