lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Apr 2020 16:37:12 +0200 From: Andrew Lunn <andrew@...n.ch> To: Colin King <colin.king@...onical.com> Cc: Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>, Michael Walle <michael@...le.cc>, Guenter Roeck <linux@...ck-us.net>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][next] net: phy: bcm54140: fix less than zero comparison on an unsigned On Thu, Apr 23, 2020 at 03:10:16PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Currently the unsigned variable tmp is being checked for an negative > error return from the call to bcm_phy_read_rdb and this can never > be true since tmp is unsigned. Fix this by making tmp a plain int. > > Addresses-Coverity: ("Unsigned compared against 0") I thought 0 was unsigned? > Fixes: 4406d36dfdf1 ("net: phy: bcm54140: add hwmon support") > Signed-off-by: Colin Ian King <colin.king@...onical.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists