netdev - Re: [RFC PATCH v5 01/16] RDMA/irdma: Add driver framework definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200423150201.GY26002@ziepe.ca>
Date:   Thu, 23 Apr 2020 12:02:01 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     "Saleem, Shiraz" <shiraz.saleem@...el.com>
Cc:     Leon Romanovsky <leon@...nel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [RFC PATCH v5 01/16] RDMA/irdma: Add driver framework definitions

On Thu, Apr 23, 2020 at 12:32:48AM +0000, Saleem, Shiraz wrote:

> we have a split initialization design for gen2 and future products.
> phase1 is control path resource initialization in irdma_probe_dev
> and phase-2 is the rest of the resources with the ib registration
> at the end of irdma_open. irdma_close must de-register the ib device
> which will take care of ibdev free too. So it makes sense to keep
> allocation of the ib device in irdma_open.

The best driver pattern is to allocate the ib_device at the very start
of probe() and use this to anchor all the device resources and
memories.

The whole close/open thing is really weird, you should get rid of it.

Jason