lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 23 Apr 2020 09:49:48 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     khalasa@...p.pl, davem@...emloft.net, linus.walleij@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: ethernet: ixp4xx: Add error handling
 inixp4xx_eth_probe()

Hi, Jackub:

On 2020/4/23 8:21, Jakub Kicinski wrote:
> On Wed, 22 Apr 2020 09:09:22 +0800 Tang Bin wrote:
>> The function ixp4xx_eth_probe() does not perform sufficient error
>> checking after executing devm_ioremap_resource(), which can result
>> in crashes if a critical error path is encountered.
>>
>> Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource")
>>
> No extra lines, between the tags, though, please.

Got it, thanks for your guidance, I'll fix it and send v3 for you.

Thanks,

Tang Bin

>
>> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
>> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>


Powered by blists - more mailing lists