netdev - Re: [PATCH net-next] ipv6: Implement draft-ietf-6man-rfc4941bis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200423.122640.181542852051859304.davem@davemloft.net>
Date:   Thu, 23 Apr 2020 12:26:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fgont@...networks.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: Implement draft-ietf-6man-rfc4941bis

From: Fernando Gont <fgont@...networks.com>
Date: Sun, 19 Apr 2020 09:16:58 -0300

> @@ -1306,12 +1304,11 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)
>  	in6_ifa_put(ifp);
>  }
>  
> -static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp,
> -				struct inet6_ifaddr *ift,
> -				bool block)
> +static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
>  {
>  	struct inet6_dev *idev = ifp->idev;
> -	struct in6_addr addr, *tmpaddr;
> +	struct in6_addr addr;
> +	struct inet6_ifaddr *ift;
>  	unsigned long tmp_tstamp, age;
>  	unsigned long regen_advance;
>  	struct ifa6_config cfg;

Please preserve the reverse christmas tree ordering of local variables
here.

Thank you.