netdev - Re: [PATCH v3] net: ethernet: ixp4xx: Add error handling in ixp4xx_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200423.153303.460318719995342920.davem@davemloft.net>
Date:   Thu, 23 Apr 2020 15:33:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tangbin@...s.chinamobile.com
Cc:     kuba@...nel.org, khalasa@...p.pl, linus.walleij@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH v3] net: ethernet: ixp4xx: Add error handling in
 ixp4xx_eth_probe()

From: Tang Bin <tangbin@...s.chinamobile.com>
Date: Thu, 23 Apr 2020 10:16:31 +0800

> The function ixp4xx_eth_probe() does not perform sufficient error
> checking after executing devm_ioremap_resource(), which can result
> in crashes if a critical error path is encountered.
> 
> Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource")
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

Applied, thank you.