netdev - Re: [PATCH net] net: bcmgenet: correct per TX/RX ring statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6e9fbce-247b-d101-2d15-217332bc9459@gmail.com>
Date:   Thu, 23 Apr 2020 15:46:37 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: correct per TX/RX ring statistics



On 4/23/2020 3:44 PM, Doug Berger wrote:
> The change to track net_device_stats per ring to better support SMP
> missed updating the rx_dropped member.
> 
> The ndo_get_stats method is also needed to combine the results for
> ethtool statistics (-S) before filling in the ethtool structure.
> 
> Fixes: 37a30b435b92 ("net: bcmgenet: Track per TX/RX rings statistics")
> Signed-off-by: Doug Berger <opendmb@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks for catching that!
-- 
Florian