netdev - Re: [PATCH net-next] net: dsa: felix: allow flooding for all traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200422.192645.1573131164417353209.davem@davemloft.net>
Date:   Wed, 22 Apr 2020 19:26:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     horatiu.vultur@...rochip.com, andrew@...n.ch, f.fainelli@...il.com,
        vivien.didelot@...il.com, joergen.andreasen@...rochip.com,
        allan.nielsen@...rochip.com, claudiu.manoil@....com,
        netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        alexandru.marginean@....com, xiaoliang.yang_1@....com,
        yangbo.lu@....com, po.liu@....com
Subject: Re: [PATCH net-next] net: dsa: felix: allow flooding for all
 traffic classes

From: Vladimir Oltean <olteanv@...il.com>
Date: Tue, 21 Apr 2020 21:13:47 +0300

> From: Xiaoliang Yang <xiaoliang.yang_1@....com>
> 
> Right now it can be seen that the VSC9959 (Felix) switch will not flood
> frames if they have a VLAN tag with a PCP of 1-7 (nonzero).
> 
> It turns out that Felix is quite different from its cousin, Ocelot, in
> that frame flooding can be allowed/denied per traffic class. Where
> Ocelot has 1 instance of the ANA_FLOODING register, Felix has 8.
> 
> The approach that this driver is going to take is "thanks, but no
> thanks". We have no use case of limiting the flooding domain based on
> traffic class, so we just want to allow packets to be flooded, no matter
> what traffic class they have.
> 
> So we copy the line of code from ocelot.c which does the one-shot
> initialization of the flooding PGIDs, and we add it to felix.c as well -
> except replicated 8 times.
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Applied, thanks.