netdev - Re: [PATCH net-next v2] macvlan: silence RCU list debugging warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200422.193400.634370651127465511.davem@davemloft.net>
Date:   Wed, 22 Apr 2020 19:34:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     edumazet@...gle.com, gustavo@...eddedor.com, ap420073@...il.com,
        richardcochran@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] macvlan: silence RCU list debugging warning

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Wed, 22 Apr 2020 10:11:35 +0800

> macvlan_hash_lookup() uses list_for_each_entry_rcu() for traversing
> should either under RCU in fast path or the protection of rtnl_mutex.
> 
> In the case of holding RTNL, we should add the corresponding lockdep
> expression to silence the following false-positive warning:
> 
> =============================
> WARNING: suspicious RCU usage
> 5.7.0-rc1-next-20200416-00003-ga3b8d28bc #1 Not tainted
> -----------------------------
> drivers/net/macvlan.c:126 RCU-list traversed in non-reader section!!
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied, thanks Wei.