netdev - Re: [PATCH net] mptcp: fix data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200422.194647.2015117902662502050.davem@davemloft.net>
Date:   Wed, 22 Apr 2020 19:46:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        kuba@...nel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: fix data_fin handing in RX path

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 22 Apr 2020 18:24:56 +0200

> The data fin flag is set only via a DSS option, but
> mptcp_incoming_options() copies it unconditionally from the
> provided RX options.
> 
> Since we do not clear all the mptcp sock RX options in a
> socket free/alloc cycle, we can end-up with a stray data_fin
> value while parsing e.g. MPC packets.
> 
> That would lead to mapping data corruption and will trigger
> a few WARN_ON() in the RX path.
> 
> Instead of adding a costly memset(), fetch the data_fin flag
> only for DSS packets - when we always explicitly initialize
> such bit at option parsing time.
> 
> Fixes: 648ef4b88673 ("mptcp: Implement MPTCP receive path")
> Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied and queued up for v5.6 -stable, thanks.