netdev - Re: [PATCH net] ipv4: Update fib_select_default to handle nexthop objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Apr 2020 19:58:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     kuba@...nel.org, netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] ipv4: Update fib_select_default to handle nexthop
 objects

From: David Ahern <dsahern@...nel.org>
Date: Wed, 22 Apr 2020 15:40:20 -0600

> From: David Ahern <dsahern@...il.com>
> 
> A user reported [0] hitting the WARN_ON in fib_info_nh:
 ...
> The WARN_ON is triggered in fib_select_default which is invoked when
> there are multiple default routes. Update the function to use
> fib_info_nhc and convert the nexthop checks to use fib_nh_common.
> 
> Add test case that covers the affected code path.
> 
> [0] https://github.com/FRRouting/frr/issues/6089
> 
> Fixes: 493ced1ac47c ("ipv4: Allow routes to use nexthop objects")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks.