netdev - Re: [PATCH bpf] libbpf: Only check mode flags in get_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+QAo--54s1fOrbA4TLvc_qa5+z4rs+MPZiQE8Vhj9+YQ@mail.gmail.com>
Date:   Wed, 22 Apr 2020 22:08:26 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrey Ignatov <rdna@...com>
Cc:     David Ahern <dsahern@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH bpf] libbpf: Only check mode flags in get_xdp_id

On Mon, Apr 20, 2020 at 9:27 AM Andrey Ignatov <rdna@...com> wrote:
>
> David Ahern <dsahern@...nel.org> [Mon, 2020-04-20 09:18 -0700]:
> > From: David Ahern <dsahern@...il.com>
> >
> > The commit in the Fixes tag changed get_xdp_id to only return prog_id
> > if flags is 0, but there are other XDP flags than the modes - e.g.,
> > XDP_FLAGS_UPDATE_IF_NOEXIST. Since the intention was only to look at
> > MODE flags, clear other ones before checking if flags is 0.
> >
> > Fixes: f07cbad29741 ("libbpf: Fix bpf_get_link_xdp_id flags handling")
> > Signed-off-by: David Ahern <dsahern@...il.com>
> > Cc: Andrey Ignatov <rdna@...com>
>
> Makes sense. Thanks.
>
> Acked-by: Andrey Ignatov <rdna@...com>

Applied. Thanks