netdev - Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200424132233.GA18127@renesas.com>
Date:   Fri, 24 Apr 2020 09:22:34 -0400
From:   Vincent Cheng <vincent.cheng.xh@...esas.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     richardcochran@...il.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary
 comparison

>Reported-by: Hulk Robot <hulkci@...wei.com>
>Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>---
> drivers/ptp/ptp_clockmatrix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
>index 032e112..56aee4f 100644
>--- a/drivers/ptp/ptp_clockmatrix.c
>+++ b/drivers/ptp/ptp_clockmatrix.c
>@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
> 
> 			/* Page size 128, last 4 bytes of page skipped */
> 			if (((loaddr > 0x7b) && (loaddr <= 0x7f))
>-			     || ((loaddr > 0xfb) && (loaddr <= 0xff)))
>+			     || loaddr > 0xfb)
> 				continue;
> 
> 			err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));

Thank-you for the fix.

Reviewed-by: Vincent Cheng  <vincent.cheng.xh@...esas.com>