netdev - Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPpH65w0Lz2C+T8Zqa43OJgvM1Ky9VVsYafR9OkgFVCTnV_5dw@mail.gmail.com>
Date:   Fri, 24 Apr 2020 18:58:50 +0200
From:   Andrea Claudi <aclaudi@...hat.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        linux-netdev <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>, daniel@...earbox.net,
        asmadeus@...ewreck.org
Subject: Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

On Thu, Apr 23, 2020 at 7:59 PM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> From: Jamal Hadi Salim <jhs@...atatu.com>
>
> Changes from V2:
>  1) Dont initialize tmp on stack (Stephen)
>  2) Dont look at the return code of snprintf (Dominique)
>  3) Set errno to EINVAL instead of returning -EINVAL for consistency (Dominique)
>
> Changes from V1:
>  1) use snprintf instead of sprintf and fix corresponding error message.
>  Caught-by: Dominique Martinet <asmadeus@...ewreck.org>
>  2) Fix memory leak and extraneous free() in error path
>
> Jamal Hadi Salim (2):
>   bpf: Fix segfault when custom pinning is used
>   bpf: Fix mem leak and extraneous free() in error path
>
>  lib/bpf.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
>
> --
> 2.20.1
>

Acked-by: Andrea Claudi <aclaudi@...hat.com>