netdev - Re: [PATCH -next] net/mlx4_core: Add missing iounmap() in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad1635d845bb364f02010f61ab1240860df14f9a.camel@mellanox.com>
Date:   Fri, 24 Apr 2020 19:48:45 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "zou_wei@...wei.com" <zou_wei@...wei.com>,
        Tariq Toukan <tariqt@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] net/mlx4_core: Add missing iounmap() in error path

On Fri, 2020-04-24 at 21:53 +0800, Zou Wei wrote:
> This fixes the following coccicheck warning:
> 
> drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing
> iounmap;
> ioremap on line 190 and execution via conditional on line 198
> 
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids
> have been used")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/crdump.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/crdump.c
> b/drivers/net/ethernet/mellanox/mlx4/crdump.c
> index 73eae80e..ac5468b 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/crdump.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/crdump.c
> @@ -197,6 +197,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev)
>  	err = devlink_region_snapshot_id_get(devlink, &id);
>  	if (err) {
>  		mlx4_err(dev, "crdump: devlink get snapshot id err
> %d\n", err);
> +		iounmap(cr_space);
>  		return err;
>  	}
>  

Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>