netdev - Re: [PATCH bpf-next] tools/runqslower: ensure own vmlinux.h is picked up first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQL6Q5KCiUed2ckP=9kmW8ogoCoSyUU4G96Z7SCku_ngug@mail.gmail.com>
Date:   Fri, 24 Apr 2020 17:46:31 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] tools/runqslower: ensure own vmlinux.h is picked
 up first

On Tue, Apr 21, 2020 at 6:24 PM Andrii Nakryiko <andriin@...com> wrote:
>
> Reorder include paths to ensure that runqslower sources are picking up
> vmlinux.h, generated by runqslower's own Makefile. When runqslower is built
> from selftests/bpf, due to current -I$(BPF_INCLUDE) -I$(OUTPUT) ordering, it
> might pick up not-yet-complete vmlinux.h, generated by selftests Makefile,
> which could lead to compilation errors like [0]. So ensure that -I$(OUTPUT)
> goes first and rely on runqslower's Makefile own dependency chain to ensure
> vmlinux.h is properly completed before source code relying on it is compiled.
>
>   [0] https://travis-ci.org/github/libbpf/libbpf/jobs/677905925
>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied to bpf tree. Thanks