netdev - Re: [PATCH net-next 08/17] net: atlantic: A2 driver-firmware interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200424.182532.868703272847758939.davem@davemloft.net>
Date:   Fri, 24 Apr 2020 18:25:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     irusskikh@...vell.com, netdev@...r.kernel.org,
        mstarovoitov@...vell.com, dbogdanov@...vell.com
Subject: Re: [PATCH net-next 08/17] net: atlantic: A2 driver-firmware
 interface

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 24 Apr 2020 17:44:47 -0700

> On Fri, 24 Apr 2020 10:27:20 +0300 Igor Russkikh wrote:
>> +/* Start of HW byte packed interface declaration */
>> +#pragma pack(push, 1)
> 
> Does any structure here actually require packing?

Yes, please use the packed attribute as an absolute _last_ resort.