netdev - Re: [PATCH v2 bpf] bpf: fix leak in LINK_UPDATE and enforce empty old_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzbPpj0FDT1=XRSi7xXVgRH29XYFfLxZhpKvO9DxZg+Kag@mail.gmail.com>
Date:   Fri, 24 Apr 2020 19:12:24 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v2 bpf] bpf: fix leak in LINK_UPDATE and enforce empty old_prog_fd

On Fri, Apr 24, 2020 at 5:31 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Thu, Apr 23, 2020 at 10:21 PM Andrii Nakryiko <andriin@...com> wrote:
> >
> > Fix bug of not putting bpf_link in LINK_UPDATE command.
> > Also enforce zeroed old_prog_fd if no BPF_F_REPLACE flag is specified.
> >
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> Applied. Thanks

Oops, forgot to include Fixes tag :( If it's not too late, can you please add?

Fixes: 0c991ebc8c69 ("bpf: Implement bpf_prog replacement for an
active bpf_cgroup_link")

Thank you!