netdev - Re: [PATCH] net: macb: fix an issue about leak related to system resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0891e70-d39f-7822-f81a-04eb824c6fd0@web.de>
Date:   Sat, 25 Apr 2020 19:00:35 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Yash Shah <yash.shah@...ive.com>
Subject: Re: [PATCH] net: macb: fix an issue about leak related to system
 resources

> A call of the function macb_init() can fail in the function
> fu540_c000_init. The related system resources were not released
> then. use devm_ioremap() to replace ioremap() for fix it.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] net: macb: Use devm_ioremap() in fu540_c000_init()

   Change description:
   A call of the macb_init() function can fail here.
   The corresponding system resources were not released then.
   Thus replace a call of the ioremap() function by devm_ioremap().


Regards,
Markus