netdev - Re: [PATCH net-next v1 2/9] net: phy: Add support for polling cable test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7557316a-fc27-ac05-6f6d-b9bac81afd82@gmail.com>
Date:   Sat, 25 Apr 2020 12:49:46 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH net-next v1 2/9] net: phy: Add support for polling cable
 test

Hi Andrew,

On 4/25/2020 11:06 AM, Andrew Lunn wrote:
> Some PHYs are not capable of generating interrupts when a cable test
> finished. They do however support interrupts for normal operations,
> like link up/down. As such, the PHY state machine would normally not
> poll the PHY.
> 
> Add support for indicating the PHY state machine must poll the PHY
> when performing a cable test.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

If you started a cable test and killed the ethtool process before the
cable diagnostics are available, the state machine gets stuck in that
state, so we should find a way to propagate the signal all the way to
the PHY library somehow.
-- 
Florian