netdev - Re: [PATCH bpf-next] bpf: fix missing bpf_base_func_proto in cgroup_base_func_proto for CGROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200426155920.g7gfzt5w6crxmvev@ast-mbp>
Date:   Sun, 26 Apr 2020 08:59:20 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
        ast@...nel.org, daniel@...earbox.net,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf-next] bpf: fix missing bpf_base_func_proto in
 cgroup_base_func_proto for CGROUP_NET=n

On Fri, Apr 24, 2020 at 04:59:41PM -0700, Stanislav Fomichev wrote:
> linux-next build bot reported compile issue [1] with one of its
> configs. It looks like when we have CONFIG_NET=n and
> CONFIG_BPF{,_SYSCALL}=y, we are missing the bpf_base_func_proto
> definition (from net/core/filter.c) in cgroup_base_func_proto.
> 
> I'm reshuffling the code a bit to make it work. The common helpers
> are moved into kernel/bpf/helpers.c and the bpf_base_func_proto is
> exported from there.
> Also, bpf_get_raw_cpu_id goes into kernel/bpf/core.c akin to existing
> bpf_user_rnd_u32.
> 
> [1] https://lore.kernel.org/linux-next/CAKH8qBsBvKHswiX1nx40LgO+BGeTmb1NX8tiTttt_0uu6T3dCA@mail.gmail.com/T/#mff8b0c083314c68c2e2ef0211cb11bc20dc13c72
> 
> Fixes: 76800cfc27c6 ("bpf: Enable more helpers for BPF_PROG_TYPE_CGROUP_{DEVICE,SYSCTL,SOCKOPT}")
> Cc: Andrii Nakryiko <andriin@...com>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Applied, Thanks