netdev - Re: [PATCH net-next v1 3/9] net: ethtool: netlink: Add support for triggering a cable test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200426205016.GE23225@lion.mk-sys.cz>
Date:   Sun, 26 Apr 2020 22:50:16 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH net-next v1 3/9] net: ethtool: netlink: Add support for
 triggering a cable test

On Sun, Apr 26, 2020 at 10:38:33PM +0200, Andrew Lunn wrote:
> > 
> > As you don't send a reply message, you don't need
> > ETHTOOL_MSG_CABLE_TEST_ACT_REPLY either (we may introduce it later if
> > there is a reply message).
> 
> One thing i was thinking about is sending user space a cookie at this
> point, to help pair the request to the multicasted results. Then the
> reply would be useful.

You could use nl_set_extack_cookie_u64() for this - it would be similar
to the nl80211 use case it was introduced for. Of course, there may be
other reasons to introduce a reply, I only suggest not to add the
message type id until we actually use it.

Michal