netdev - Re: [PATCH net-next v2 2/3] ipv4: add sysctl for nexthop api compatibility mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d13007-1b31-7d2b-dc85-c28d73e0985b@infradead.org>
Date:   Sat, 25 Apr 2020 19:08:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, dsahern@...il.com,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
        bpoirier@...ulusnetworks.com
Subject: Re: [PATCH net-next v2 2/3] ipv4: add sysctl for nexthop api
 compatibility mode

On 4/25/20 5:48 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Current route nexthop API maintains user space compatibility
> with old route API by default. Dumps and netlink notifications
> support both new and old API format. In systems which have
> moved to the new API, this compatibility mode cancels some
> of the performance benefits provided by the new nexthop API.
> 
> This patch adds new sysctl nexthop_compat_mode which is on
> by default but provides the ability to turn off compatibility
> mode allowing systems to run entirely with the new routing
> API. Old route API behaviour and support is not modified by this
> sysctl.
> 
> Uses a single sysctl to cover both ipv4 and ipv6 following
> other sysctls. Covers dumps and delete notifications as
> suggested by David Ahern.
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
>  include/net/netns/ipv4.h   | 2 ++
>  net/ipv4/af_inet.c         | 1 +
>  net/ipv4/fib_semantics.c   | 3 +++
>  net/ipv4/nexthop.c         | 5 +++--
>  net/ipv4/sysctl_net_ipv4.c | 7 +++++++
>  net/ipv6/route.c           | 3 ++-
>  6 files changed, 18 insertions(+), 3 deletions(-)

Hi,

Are net sysctls supposed to be documented, e.g. in
Documentation/admin-guide/sysctl/net.rst?

thanks.
-- 
~Randy