netdev - RE: [PATCH V1 net-next 01/13] net: ena: fix error returning in ena_com_get_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76237aeabc2e4ce7bf279892c225371f@EX13D11EUC003.ant.amazon.com>
Date:   Sun, 26 Apr 2020 09:43:53 +0000
From:   "Jubran, Samih" <sameehj@...zon.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kiyanovski, Arthur" <akiyano@...zon.com>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Dagan, Noam" <ndagan@...zon.com>
Subject: RE: [PATCH V1 net-next 01/13] net: ena: fix error returning in
 ena_com_get_hash_function()



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, April 23, 2020 3:36 AM
> To: Jubran, Samih <sameehj@...zon.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Kiyanovski, Arthur
> <akiyano@...zon.com>; Woodhouse, David <dwmw@...zon.co.uk>;
> Machulsky, Zorik <zorik@...zon.com>; Matushevsky, Alexander
> <matua@...zon.com>; Bshara, Saeed <saeedb@...zon.com>; Wilson,
> Matt <msw@...zon.com>; Liguori, Anthony <aliguori@...zon.com>;
> Bshara, Nafea <nafea@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>;
> Belgazal, Netanel <netanel@...zon.com>; Saidi, Ali
> <alisaidi@...zon.com>; Herrenschmidt, Benjamin <benh@...zon.com>;
> Dagan, Noam <ndagan@...zon.com>
> Subject: RE: [EXTERNAL] [PATCH V1 net-next 01/13] net: ena: fix error
> returning in ena_com_get_hash_function()
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> On Wed, 22 Apr 2020 08:16:16 +0000 sameehj@...zon.com wrote:
> > From: Arthur Kiyanovski <akiyano@...zon.com>
> >
> > In case the "func" parameter is NULL we now return "-EINVAL".
> > This shouldn't happen in general, but when it does happen, this is the
> > proper way to handle it.
> >
> > We also check func for NULL in the beginning of the function, as there
> > is no reason to do all the work and realize in the end of the function
> > it was useless.
> >
> > Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic
> > Network Adapters (ENA)")
> 
> Also, why the fixes tag? Is this a fix for a user-visible problem?
Will drop.
> 
> > Signed-off-by: Sameeh Jubran <sameehj@...zon.com>
> > Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>