lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Apr 2020 14:41:37 +0100 From: Russell King - ARM Linux admin <linux@...linux.org.uk> To: Calvin Johnson <calvin.johnson@....nxp.com> Cc: linux.cj@...il.com, Jeremy Linton <jeremy.linton@....com>, Andrew Lunn <andrew@...n.ch>, Andy Shevchenko <andy.shevchenko@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Cristi Sovaiala <cristian.sovaiala@....com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>, Ioana Ciornei <ioana.ciornei@....com>, Madalin Bucur <madalin.bucur@....nxp.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, Diana Madalina Craciun <diana.craciun@....com>, Laurentiu Tudor <laurentiu.tudor@....com>, linux-acpi@...r.kernel.org, Marcin Wojtas <mw@...ihalf.com>, Makarand Pawagi <makarand.pawagi@....com>, "Rajesh V . Bikkina" <rajesh.bikkina@....com>, Varun Sethi <V.Sethi@....com>, linux-kernel@...r.kernel.org, Pankaj Bansal <pankaj.bansal@....com>, "David S. Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com> Subject: Re: [net-next PATCH v2 1/3] device property: Introduce phy related fwnode functions On Mon, Apr 27, 2020 at 06:54:07PM +0530, Calvin Johnson wrote: > +/** > + * device_phy_find_device - For the given device, get the phy_device > + * @dev: Pointer to the given device > + * > + * If successful, returns a pointer to the phy_device with the embedded > + * struct device refcount incremented by one, or NULL on failure. It probably makes sense to refer the reader to the return conditions for fwnode_phy_find_device() so that should fwnode_phy_find_device() be updated, there's no need to modify multiple locations. > + */ > +struct phy_device *device_phy_find_device(struct device *dev) > +{ > + return fwnode_phy_find_device(dev_fwnode(dev)); > +} > +EXPORT_SYMBOL_GPL(device_phy_find_device); > + > +/** > + * fwnode_get_phy_node - Get the phy_node using the named reference. > + * @fwnode: Pointer to fwnode from which phy_node has to be obtained. > + * > + * Returns pointer to the phy fwnode, or ERR_PTR. Caller is responsible to > + * call fwnode_handle_put() on the returned phy fwnode pointer. This one even more so - fwnode_find_reference() is in an entirely separate file, so the comment could well be missed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Powered by blists - more mailing lists