lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Apr 2020 00:14:44 -0400 From: Rylan Dmello <mail@...an.coffee> To: Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, netdev@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Benjamin Poirier <bpoirier@...e.com>, Jiri Pirko <jpirko@...hat.com> Subject: [PATCH 2/3] staging: qlge: Remove print statement for vlgrp field Remove statement that tries to print the non-existent 'vlgrp' field in the 'ql_adapter' struct, which causes a compilation failure when QL_DEV_DUMP is set. vlgrp seems to have been removed from ql_adapter as a part of commit 18c49b91777c ("qlge: do vlan cleanup") in 2011. vlgrp might be replaced by the 'active_vlans' array introduced in the aforementioned commit. But I'm not sure if printing all 64 values of that array would help with debugging this driver, so I'm leaving it out of the debug code in this patch. Signed-off-by: Rylan Dmello <mail@...an.coffee> --- drivers/staging/qlge/qlge_dbg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index e0dcdc452e2e..bf157baace54 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -1570,7 +1570,6 @@ void ql_dump_qdev(struct ql_adapter *qdev) int i; DUMP_QDEV_FIELD(qdev, "%lx", flags); - DUMP_QDEV_FIELD(qdev, "%p", vlgrp); DUMP_QDEV_FIELD(qdev, "%p", pdev); DUMP_QDEV_FIELD(qdev, "%p", ndev); DUMP_QDEV_FIELD(qdev, "%d", chip_rev_id); -- 2.26.2
Powered by blists - more mailing lists