netdev - Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB6941D611F6EF67BB42826D4EEEAF0@VI1PR04MB6941.eurprd04.prod.outlook.com>
Date:   Mon, 27 Apr 2020 15:19:54 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Andrew Lunn <andrew@...n.ch>, Andy Duan <fugang.duan@....com>
CC:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Chris Healy <Chris.Healy@....aero>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with
 polled IO

Hello,

This patch breaks network boot on at least imx8mm-evk. Boot works if I 
revert just commit 29ae6bd1b0d8 ("net: ethernet: fec: Replace interrupt 
driven MDIO with polled IO") on top of next-20200424.

Running with tp_printk trace_event=mdio:* shows the phy identifier is 
not read correctly:

BAD:
[    9.058457] mdio_access: 30be0000.ethernet-1 read  phy:0x00 reg:0x02 
val:0x0000
[    9.065857] mdio_access: 30be0000.ethernet-1 read  phy:0x00 reg:0x03 
val:0x0000

GOOD:
[    9.100485] mdio_access: 30be0000.ethernet-1 read  phy:0x00 reg:0x02 
val:0x004d
[    9.108271] mdio_access: 30be0000.ethernet-1 read  phy:0x00 reg:0x03 
val:0xd074

I don't have the original patch in my inbox, hope the manual In-Reply-To 
header is OK.

--
Regards,
Leonard