netdev - Re: [PATCH v3 bpf-next 00/15] net: Add support for XDP in egress path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zhaxx8cr.fsf@toke.dk>
Date:   Mon, 27 Apr 2020 17:21:24 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org,
        prashantbhole.linux@...il.com, jasowang@...hat.com,
        brouer@...hat.com, toshiaki.makita1@...il.com,
        daniel@...earbox.net, john.fastabend@...il.com, ast@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com, andriin@...com,
        dsahern@...il.com
Subject: Re: [PATCH v3 bpf-next 00/15] net: Add support for XDP in egress path

David Ahern <dsahern@...nel.org> writes:

> From: David Ahern <dsahern@...il.com>
>
> This series adds support for XDP in the egress path by introducing
> a new XDP attachment type, BPF_XDP_EGRESS

Can't find anything more to complain about :)

Ran a quick performance test: On a test using xdp_redirect_map from
samples/bpf, which gets 8.15 Mpps normally, loading an XDP egress
program on the target interface drops performance to 7.55 Mpps. So ~600k
pps, or ~9.5ns overhead for the egress program. So other than the nit in
the bpftool patch, please consider the series:

Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>