lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Apr 2020 11:12:20 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Edward Cree <ecree@...arflare.com> Cc: Jiri Pirko <jiri@...nulli.us>, Pablo Neira Ayuso <pablo@...filter.org>, Florian Westphal <fw@...len.de>, <netfilter-devel@...r.kernel.org>, <davem@...emloft.net>, <netdev@...r.kernel.org> Subject: Re: [PATCH net] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DISABLED On Mon, 27 Apr 2020 15:31:48 +0100 Edward Cree wrote: > On 22/04/2020 19:37, Jiri Pirko wrote: > > "Any" can't be "don't care". TC User expects stats. That's default. > > > > Let's have "don't care" bit only and set it for > > ethtool/netfilter/flowtable. Don't change any. Teach the drivers to deal > > with "don't care", most probably using the default checker. > I think the right solution is either this, or the semantically-similar > approach of "0 means don't care, we have a bit for disabled, and ANY > (the TC default) is "all the bits except disabled", i.e. > DELAYED | IMMEDIATE. That seems slightly cleaner to me, as then non- > zero settings are always "here is a bitmask of options, driver may > choose any of them". (And 0 differs from DELAYED | IMMEDIATE | DISABLED > only in that if new bits are added to kernel, 0 includes them.) +1 > And of course either way the TC uAPI needs to be able to specify the > new "don't care" option.
Powered by blists - more mailing lists