netdev - Re: [PATCH net-next 00/13] mlxsw: Rework matchall offloading plumbing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200427.124350.787548116668309902.davem@davemloft.net>
Date:   Mon, 27 Apr 2020 12:43:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net-next 00/13] mlxsw: Rework matchall offloading
 plumbing

From: Ido Schimmel <idosch@...sch.org>
Date: Mon, 27 Apr 2020 18:12:57 +0300

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Jiri says:
> 
> Currently the matchall and flower are handled by registering separate
> callbacks in mlxsw. That leads to faulty indication "in_hw_count 2" in
> filter show command for every inserted flower filter. That happens
> because matchall callback just blindly returns 0 for it and it is
> wrongly accounted for as "the offloader".
> 
> I inspected different ways to fix this problem. The only clean solution
> is to rework handling of matchall in mlxsw a bit. The driver newely
> registers one callback for bound block which is called for both matchall
> and flower filter insertions.
> 
> On the way, iron out the matchall code a bit, push it into a separate
> file etc.

Series applied, thanks.