netdev - Re: [EXT] Re: [PATCH net-next 08/17] net: atlantic: A2 driver-firmware interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be1461d3-f87e-0bfa-0b37-6eef4a2519e6@marvell.com>
Date:   Mon, 27 Apr 2020 23:04:24 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
        "Mark Starovoytov" <mstarovoitov@...vell.com>,
        Dmitry Bogdanov <dbogdanov@...vell.com>
Subject: Re: [EXT] Re: [PATCH net-next 08/17] net: atlantic: A2
 driver-firmware interface

>>> Please remove __packed unless you can prove it matters.  
>>
>> Just double checked the layout without packed pragma, below is what
> pahole
>> diff gives just on one structure.
> 
> Okay, then mark the appropriate fields of that structure as packed.
> I looked at first 4 structures and they should require no packing.

Hi Jakub.

This means I have to dig each and every structure in this header and
understand whether it may suffer from implicit alignment/holes or not.

Not mentioning the fact that these alignment rules are different on other
compilers, or on say 32-bit archs.

I also see a lot of code through the kernel using pack(1) for the exact same
reason - declare hw sensitive structures and eliminate any unexpected holes.

Regards,
  Igor