netdev - Re: [v2 2/3] net: qrtr: Add MHI transport layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Apr 2020 12:27:37 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Markus Elfring <Markus.Elfring@....de>,
        Chris Lew <clew@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org
CC:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hemant Kumar <hemantk@...eaurora.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Siddartha Mohanadoss <smohanad@...eaurora.org>
Subject: Re: [v2 2/3] net: qrtr: Add MHI transport layer



On 27 April 2020 12:20:43 PM IST, Markus Elfring <Markus.Elfring@....de> wrote:
>>> I propose again to add a jump target so that a bit of exception
>handling code
>>> can be better reused at the end of this function implementation.
>>>
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b2768df24ec400dd4f7fa79542f797e904812053#n450
>>>
>>
>> Matter of taste! goto's are really useful if there are multiple exit
>paths
>> available. But in this case there is only one and I don't think we
>may add
>> anymore in future. So I'll keep it as it is.
>
>Do you hope that an other optimiser software will avoid duplicate code
>like kfree_skb(skb) calls from if branches?
>

Doh. I didn't notice the previous kfree in skb_linearize(). Will spin v3 incorporating this change. 

Thanks, 
Mani

>Regards,
>Markus

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.