netdev - Re: [PATCH net-next v3 00/11] implement DEVLINK_CMD_REGION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200427172653.483e032d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 27 Apr 2020 17:26:53 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next v3 00/11] implement DEVLINK_CMD_REGION_NEW

On Thu, 26 Mar 2020 11:37:07 -0700 Jacob Keller wrote:
> This series adds support for the DEVLINK_CMD_REGION_NEW operation, used to
> enable userspace requesting a snapshot of a region on demand.
> 
> This can be useful to enable adding regions for a driver for which there is
> no trigger to create snapshots. By making this a core part of devlink, there
> is no need for the drivers to use a separate channel such as debugfs.
> 
> The primary intent for this kind of region is to expose device information
> that might be useful for diagnostics and information gathering.
> 
> The first few patches refactor regions to support a new ops structure for
> extending the available operations that regions can perform. This includes
> converting the destructor into an op from a function argument.
> 
> Next, patches refactor the snapshot id allocation to use an xarray which
> tracks the number of current snapshots using a given id. This is done so
> that id lifetime can be determined, and ids can be released when no longer
> in use.
> 
> Without this change, snapshot ids remain used forever, until the snapshot_id
> count rolled over UINT_MAX.
> 
> Finally, code to enable the previously unused DEVLINK_CMD_REGION_NEW is
> added. This code enforces that the snapshot id is always provided, unlike
> previous revisions of this series.
> 
> Finally, a patch is added to enable using this new command via the .snapshot
> callback in both netdevsim and the ice driver.
> 
> For the ice driver, a new "nvm-flash" region is added, which will enable
> read access to the NVM flash contents. The intention for this is to allow
> diagnostics tools to gather information about the device. By using a
> snapshot and gathering the NVM contents all at once, the contents can be
> atomic.

Hi Jake,

does iproute2 needs some patches to make this work?

./devlink region new netdevsim/netdevsim1/dummy snapshot_id 1
Command "new" not found