netdev - Re: [PATCH v2 bpf-next 2/3] libbpf: refactor map creation logic and fix cleanup leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87blnbx4wc.fsf@toke.dk>
Date:   Tue, 28 Apr 2020 12:48:19 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH v2 bpf-next 2/3] libbpf: refactor map creation logic and fix cleanup leak

Andrii Nakryiko <andriin@...com> writes:

> Factor out map creation and destruction logic to simplify code and especially
> error handling. Also fix map FD leak in case of partially successful map
> creation during bpf_object load operation.
>
> Cc: Toke Høiland-Jørgensen <toke@...hat.com>
> Fixes: 57a00f41644f ("libbpf: Add auto-pinning of maps when loading BPF objects")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Good catch on the fd leak!

Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>