netdev - Re: [PATCH iproute2] xfrm: also check for ipv6 state in xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200427181509.3f408bbd@hermes.lan>
Date:   Mon, 27 Apr 2020 18:15:09 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>, Xiumei Mu <xmu@...hat.com>,
        aclaudi@...hat.com
Subject: Re: [PATCH iproute2] xfrm: also check for ipv6 state in
 xfrm_state_keep

On Mon, 27 Apr 2020 15:14:24 +0800
Xin Long <lucien.xin@...il.com> wrote:

> As commit f9d696cf414c ("xfrm: not try to delete ipcomp states when using
> deleteall") does, this patch is to fix the same issue for ip6 state where
> xsinfo->id.proto == IPPROTO_IPV6.
> 
>   # ip xfrm state add src 2000::1 dst 2000::2 spi 0x1000 \
>     proto comp comp deflate mode tunnel sel src 2000::1 dst \
>     2000::2 proto gre
>   # ip xfrm sta deleteall
>   Failed to send delete-all request
>   : Operation not permitted
> 
> Note that the xsinfo->proto in common states can never be IPPROTO_IPV6.
> 
> Fixes: f9d696cf414c ("xfrm: not try to delete ipcomp states when using deleteall")
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied