netdev - Re: [PATCH net-next] net: sched: fallback to qdisc noqueue if default qdisc setup fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Apr 2020 14:20:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org,
        stephen@...workplumber.org, dsahern@...il.com
Subject: Re: [PATCH net-next] net: sched: fallback to qdisc noqueue if
 default qdisc setup fail

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Tue, 28 Apr 2020 13:06:10 +0200

> +	/* Detect default qdisc setup/init failed and fallback to "noqueue" */
> +	if (dev->qdisc == &noop_qdisc) {
> +		netdev_warn(dev, "default qdisc (%s) fail, fallback to %s\n",
> +			    default_qdisc_ops->id, noqueue_qdisc_ops.id);
> +		dev->priv_flags |= IFF_NO_QUEUE;

What will ever clear this IFF_NO_QUEUE bit in the future so that another
attempt can be made to attach another qdisc?

An -ENOMEM failure is transient, for example, and shouldn't disable
qdiscs forever on the device.