netdev - Re: [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzbzOqBew+kySpqNTgzXpa009KjoXOLpjZ8FvNr5Jo7gXg@mail.gmail.com>
Date:   Mon, 27 Apr 2020 18:40:04 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Carlos Antonio Neira Bustos <cneirabustos@...il.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        Yonghong Song <yhs@...com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH v17 0/3] BPF: New helper to obtain namespace data from
 current task

On Fri, Mar 13, 2020 at 5:48 AM Carlos Antonio Neira Bustos
<cneirabustos@...il.com> wrote:
>
> On Thu, Mar 12, 2020 at 05:45:09PM -0700, Alexei Starovoitov wrote:
> > On Wed, Mar 4, 2020 at 12:42 PM Carlos Neira <cneirabustos@...il.com> wrote:
> > >
> > > Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's
> > > scripts but this helper returns the pid as seen by the root namespace which is
> > > fine when a bcc script is not executed inside a container.
> > > When the process of interest is inside a container, pid filtering will not work
> > > if bpf_get_current_pid_tgid() is used.
> > > This helper addresses this limitation returning the pid as it's seen by the current
> > > namespace where the script is executing.
> > >
> > > In the future different pid_ns files may belong to different devices, according to the
> > > discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference.
> > > To address that situation the helper requires inum and dev_t from /proc/self/ns/pid.
> > > This helper has the same use cases as bpf_get_current_pid_tgid() as it can be
> > > used to do pid filtering even inside a container.
> >
> > Applied. Thanks.
> > There was one spurious trailing whitespace that I fixed in patch 3
> > and missing .gitignore update for test_current_pid_tgid_new_ns.
> > Could you please follow up with another patch to fold
> > test_current_pid_tgid_new_ns into test_progs.
> > I'd really like to consolidate all tests into single binary.
>
> Thank you very much Alexei,
> I'll start working on the follow up patch to add test_current_pid_tgid_new_ns into test_progs.
>

Hey Carlos,

Do you still plan to fold test_current_pid_tgid_new_ns into test_progs?

> Bests