netdev - Re: [PATCH V6 mlx5-next 13/16] net/mlx5: Change lag mutex lock to spin lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428232326.GA13640@mellanox.com>
Date:   Tue, 28 Apr 2020 20:23:26 -0300
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Maor Gottlieb <maorg@...lanox.com>
Cc:     davem@...emloft.net, dledford@...hat.com, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net, kuba@...nel.org,
        jiri@...lanox.com, dsahern@...nel.org, leonro@...lanox.com,
        saeedm@...lanox.com, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org, alexr@...lanox.com
Subject: Re: [PATCH V6 mlx5-next 13/16] net/mlx5: Change lag mutex lock to
 spin lock

On Sun, Apr 26, 2020 at 10:17:14AM +0300, Maor Gottlieb wrote:
> The lag lock could be a mutex, the critical section is short
> and there is no need that the thread will sleep.
> Change the lock that protects the LAG structure from mutex
> to spin lock. It is required for next patch that need to
> access this structure from context that we can't sleep.
> In addition there is no need to hold this lock when query the
> congestion counters.
> 
> Signed-off-by: Maor Gottlieb <maorg@...lanox.com>
> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/lag.c | 42 +++++++++----------
>  1 file changed, 21 insertions(+), 21 deletions(-)

Lets have these two net/ patches before the RDMA patches, it seems there is
not a reason here to send RDMA patches to net

Thanks,
Jason