netdev - re: [PATCH net-next] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6AADFAC011213A4C87B956458587ADB419A6B43E@dggeml532-mbs.china.huawei.com>
Date:   Tue, 28 Apr 2020 03:25:09 +0000
From:   "weiyongjun (A)" <weiyongjun1@...wei.com>
To:     David Lechner <david@...hnology.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Andrew Lunn <andrew@...n.ch>
CC:     "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: re: [PATCH net-next] drivers: net: davinci_mdio: fix potential NULL
 dereference in davinci_mdio_probe()

> 
> On 4/27/20 4:40 AM, Wei Yongjun wrote:
> > platform_get_resource() may fail and return NULL, so we should better
> > check it's return value to avoid a NULL pointer dereference a bit
> > later in the code.
> >
> > This is detected by Coccinelle semantic patch.
> >
> > @@
> > expression pdev, res, n, t, e, e1, e2; @@
> >
> > res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
> > + if (!res)
> > +   return -EINVAL;
> > ... when != res == NULL
> > e = devm_ioremap(e1, res->start, e2);
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> > ---
> 
> Could we use devm_platform_ioremap_resource() instead?

We cannot use devm_platform_ioremap_resource() here, see
Commit 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")

Regards