netdev - Re: [PATCH net 1/5] mptcp: consolidate synack processing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200429.115034.117126455083840977.davem@davemloft.net>
Date:   Wed, 29 Apr 2020 11:50:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com,
        mathew.j.martineau@...ux.intel.com, matthieu.baerts@...sares.net,
        kuba@...nel.org, cpaasch@...le.com, mptcp@...ts.01.org
Subject: Re: [PATCH net 1/5] mptcp: consolidate synack processing.

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 29 Apr 2020 12:41:45 +0200

> @@ -222,6 +222,7 @@ static void subflow_finish_connect(struct sock *sk, const struct sk_buff *skb)
>  {
>  	struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(sk);
>  	struct sock *parent = subflow->conn;
> +	struct tcp_sock *tp = tcp_sk(sk);

Since you introduce this 'tp' variable...

> +	} else if (subflow->request_mptcp) {
> +		tcp_sk(sk)->is_mptcp = 0;

Please use it here.

> +	}
> +
> +	if (!tcp_sk(sk)->is_mptcp)
>  		return;

And here.

Thank you.