netdev - RE: [PATCH bpf-next 2/3] selftests/bpf: Test that lookup on SOCKMAP/SOCKHASH is allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ea9d43aa9298_220d2ac81567a5b8fa@john-XPS-13-9370.notmuch>
Date:   Wed, 29 Apr 2020 12:23:38 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Joe Stringer <joe@...d.net.nz>,
        John Fastabend <john.fastabend@...il.com>,
        Lorenz Bauer <lmb@...udflare.com>,
        Martin KaFai Lau <kafai@...com>
Subject: RE: [PATCH bpf-next 2/3] selftests/bpf: Test that lookup on
 SOCKMAP/SOCKHASH is allowed

Jakub Sitnicki wrote:
> Now that bpf_map_lookup_elem() is white-listed for SOCKMAP/SOCKHASH,
> replace the tests which check that verifier prevents lookup on these map
> types with ones that ensure that lookup operation is permitted, but only
> with a release of acquired socket reference.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---

For completeness would be nice to add a test passing this into
sk_select_reuseport to cover that case as well. Could come as
a follow up patch imo.

Acked-by: John Fastabend <john.fastabend@...il.com>