netdev - Re: [PATCH net-next v2 2/7] net: bcmgenet: Fix WoL with password after deep sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ab2343d-5c3f-7d0b-2094-3c7795832bfe@gmail.com>
Date:   Wed, 29 Apr 2020 14:22:18 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/7] net: bcmgenet: Fix WoL with password
 after deep sleep

On 4/29/20 1:02 PM, Doug Berger wrote:
> Broadcom STB chips support a deep sleep mode where all register contents
> are lost. Because we were stashing the MagicPacket password into some of
> these registers a suspend into that deep sleep then a resumption would
> not lead to being able to wake-up from MagicPacket with password again.
> 
> Fix this by keeping a software copy of the password and program it
> during suspend.
> 
> Fixes: c51de7f3976b ("net: bcmgenet: add Wake-on-LAN support code")
> Suggested-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Doug Berger <opendmb@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian