netdev - Re: [PATCH v7 bpf-next 1/3] bpf: sharing bpf runtime stats with BPF_ENABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200429043940.6dirzvgh26o2hrul@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 28 Apr 2020 21:39:40 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Song Liu <songliubraving@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...nel.org,
        daniel@...earbox.net, kernel-team@...com
Subject: Re: [PATCH v7 bpf-next 1/3] bpf: sharing bpf runtime stats with
 BPF_ENABLE_STATS

On Tue, Apr 28, 2020 at 08:58:39PM -0700, Song Liu wrote:
> +
> +static int bpf_enable_stats(union bpf_attr *attr)
> +{

CHECK_ATTR() is missing which makes it non-extensible.

> +	switch (attr->enable_stats.type) {
> +	case BPF_STATS_RUNTIME_CNT:
> +		return bpf_enable_runtime_stats();
> +	default:
> +		break;
> +	}
> +	return -EINVAL;
> +}